Skip to content

Removed various fuzzies in tutorial#976

Closed
Seluj78 wants to merge 8 commits intopython:3.8from
Seluj78:tutorial-fuzzies
Closed

Removed various fuzzies in tutorial#976
Seluj78 wants to merge 8 commits intopython:3.8from
Seluj78:tutorial-fuzzies

Conversation

@Seluj78
Copy link
Collaborator

@Seluj78 Seluj78 commented Nov 5, 2019

No description provided.

@Seluj78 Seluj78 added the NEED REVIEWER This PR needs a reviewer :) label Nov 5, 2019
@Seluj78 Seluj78 self-assigned this Nov 5, 2019
@deronnax
Copy link
Collaborator

deronnax commented Nov 5, 2019

Hello. Il y a déjà la #940 sur library/controlflow

@Seluj78
Copy link
Collaborator Author

Seluj78 commented Nov 5, 2019

@deronnax il avais pas réservé 🤷‍♂

@Seluj78 Seluj78 mentioned this pull request Nov 5, 2019
Merged
@deronnax
Copy link
Collaborator

deronnax commented Nov 5, 2019

tu ne l'avais pas réservé non plus il me semble ;)

@Seluj78
Copy link
Collaborator Author

Seluj78 commented Nov 6, 2019

@deronnax Oui maiiis euuuh... J'ai le commit bit ? 😇 moi c'est des petits fix de fuzzies sur plusieurs fichiers, si on merge cette PR et on rebase la #940 alors ca ira non ? ou l'inverse

@Seluj78 Seluj78 added DO NOT MERGE Please do not merge for the moment. on hold labels Nov 15, 2019
@Seluj78
Copy link
Collaborator Author

Seluj78 commented Nov 15, 2019

En attente de merge de #940

@Seluj78 Seluj78 removed DO NOT MERGE Please do not merge for the moment. on hold labels Nov 15, 2019
@Seluj78
Copy link
Collaborator Author

Seluj78 commented Nov 15, 2019

Besoin de reviews now

awecx
awecx suggested changes Nov 17, 2019
View reviewed changes
Copy link

@awecx awecx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ai relu la PR, 2-3 choses à corriger. Vérifie aussi tes :: à la fin des blocs.

@Seluj78 Seluj78 requested a review from awecx November 18, 2019 09:56
vpoulailleau
vpoulailleau suggested changes Nov 18, 2019
View reviewed changes
Copy link
Contributor

@vpoulailleau vpoulailleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est padpo ! 😉

https://github.com/vpoulailleau/padpo

python padpo.py -p 976

vpoulailleau
vpoulailleau suggested changes Nov 19, 2019
View reviewed changes
Copy link
Contributor

@vpoulailleau vpoulailleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Le retour de padpo !

Il me dit aussi :

/tmp/padpo_too8vwdg/tutorial/interpreter.po:  76 [ Line length  ] Line too long (85 > 79): systèmes qui prennent en charge la bibliothèque `GNU Readline <https://tiswww.case.
/tmp/padpo_too8vwdg/tutorial/interpreter.po:  76 [ Line length  ] Line too long (81 > 79): l'édition de la ligne de commande gérée consiste à taper :kbd:`Control-P` dans

Mais la CI n'a pas l'air de broncher, quelqu'un sait pourquoi ?

Et sinon, maintenant je lance la commande suivante :

padpo -p 976

@awecx
Copy link

awecx commented Nov 19, 2019

Mais la CI n'a pas l'air de broncher, quelqu'un sait pourquoi ?

Le CI était encore cassé à ce moment-là : #1017

Seluj78 and others added 5 commits December 2, 2019 11:52
@Seluj78
Removed various fuzzies in tutorial
a30673d
@Seluj78
Fixes pospell
3708b77
@Seluj78 @awecx
Apply suggestions from code review
e4a9b8e 
Co-Authored-By: Antoine <43954001+awecx@users.noreply.github.com>
@Seluj78 @vpoulailleau
Apply suggestions from code review
25781b3 
Co-Authored-By: Vincent Poulailleau <vpoulailleau@gmail.com>
@Seluj78 @vpoulailleau
Update tutorial/interpreter.po
f62df71 
Co-Authored-By: Vincent Poulailleau <vpoulailleau@gmail.com>
Seluj78
Seluj78 commented Dec 2, 2019
View reviewed changes
@Seluj78
Copy link
Collaborator Author

Seluj78 commented Dec 3, 2019

need new reviews :)

JulienPalard
JulienPalard requested changes Dec 4, 2019
View reviewed changes
@Seluj78 @JulienPalard
Apply suggestions from code review
b0ecccd 
Co-Authored-By: Julien Palard <julien@palard.fr>
vpoulailleau
vpoulailleau suggested changes Dec 10, 2019
View reviewed changes
Copy link
Contributor

@vpoulailleau vpoulailleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

La CI est encore KO sur cette branche (et elle affiche OK), padpo et powrap réclament un reformattage avec powrap 😉

@JulienPalard
Copy link
Member

JulienPalard commented Dec 11, 2019

Oh maince, j'aurai parié que true && false || true valait false dans bash. Je fix !

@JulienPalard JulienPalard mentioned this pull request Dec 11, 2019
Merged
@Seluj78 Seluj78 deleted the tutorial-fuzzies branch February 15, 2021 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JulienPalard JulienPalard JulienPalard requested changes

@christopheNan christopheNan Awaiting requested review from christopheNan

@awecx awecx Awaiting requested review from awecx

+1 more reviewer

@vpoulailleau vpoulailleau vpoulailleau requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@deronnax deronnax

@Seluj78 Seluj78

Labels

NEED REVIEWER This PR needs a reviewer :)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Seluj78 @deronnax @awecx @JulienPalard @vpoulailleau